Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customization of replica set configuration #244

Open
jyemin opened this issue May 2, 2018 · 1 comment
Open

Support customization of replica set configuration #244

jyemin opened this issue May 2, 2018 · 1 comment

Comments

@jyemin
Copy link
Member

jyemin commented May 2, 2018

I'd like to be able to set writeConcernMajorityJournalDefault so that I can run a replica set with members that use the inMemory storage engine and still execute tests that use "majority" write concern. Currently there is no way to set this option.

Shane suggested a hack of adding

config['writeConcernMajorityJournalDefault'] = False

to https://github.com/10gen/mongo-orchestration/blob/master/mongo_orchestration/replica_sets.py#L174, which is my current workaround.

@ShaneHarvey
Copy link
Collaborator

One option, add a "rsConfig" parameter:

{
  "rsConfig": {"writeConcernMajorityJournalDefault": false},
  "members": [{}]
}

MO already supports a "rsSettings" paramter that maps to rsConf.settings. If we add "rsConfig" MO should not allow it to be used in combination with "rsSettings". Instead just specficy "settings" as part of the "rsConfig":

{
  "rsConfig": {
    "writeConcernMajorityJournalDefault": false,
    "settings": {"heartbeatTimeoutSecs": 20},
   },
  "members": [{}]
}

It should also be illegal to specify "members" in "rsConfig" as the per-member replica set config is specified in "members.rsParams" like this:

{
  "rsConfig": {
    "writeConcernMajorityJournalDefault": false,
    "settings": {"heartbeatTimeoutSecs": 20},
   },
  "members": [{"rsParams": {"priority": 10}}]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants