Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override doesn't work #16

Open
Michael-Reich opened this issue Feb 5, 2018 · 8 comments
Open

Override doesn't work #16

Michael-Reich opened this issue Feb 5, 2018 · 8 comments

Comments

@Michael-Reich
Copy link

I use the standard template from nuxt-starter and try to import scss to override variables. But it does not work:

@import '../node_modules/at-ui-style/src/variables/default.scss';
@import '../node_modules/at-ui-style/src/variables/timing-function.scss';

$link-color: #c03;
$btn-primary-bg: #c03;


@import '../node_modules/at-ui-style/src/mixins/index.scss';
@import '../node_modules/at-ui-style/src/core/index.scss';
@import '../node_modules/at-ui-style/src/components/index.scss';

Embeded in the Layout.vue

<template>
  <div>
    <Header/>
    <nuxt/>
  </div>
</template>

<script>
  import Vue from 'vue'
  import AtComponents from 'at-ui'
  import Header from '~/components/Header.vue'

  Vue.use(AtComponents)

  export default {
    components: {
      Header
    }
  }
</script>

<style lang="scss">
 @import '../assets/main.scss';

  img {
    image-rendering: auto;
    image-rendering: crisp-edges;
  }
</style>
@bryanculver
Copy link

I ran into the same issue. Filing a pull request to handle this.

@Michael-Reich
Copy link
Author

Thank you, did you already got accepted?

@yoyo837
Copy link

yoyo837 commented May 24, 2018

The maintainer was a bit busy recently. So...

@bryanculver
Copy link

@Michael-Reich Unfortunately it's still open: #18

@shredding
Copy link

How can we push this? The package is super awesome with this fix applied and basically useless without it.

@bryanculver
Copy link

@shredding Unfortunately we would need a maintainer, which appears to be @koppthe or @JChehe, to merge this in and they seem back up currently. There has been no response to this ticket or pull request.

@shredding
Copy link

shredding commented May 25, 2018

There has been no response

At least they maintain the same spirit as in their mobile phone contract support.

Just kidding :-)

@bryanculver
Copy link

At least they maintain the same spirit as in their mobile phone contract support.

Thankfully this isn't associated with AT&T. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants