Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-add-class throws error with SVG elements in IE 10 #87

Open
daver208 opened this issue Mar 6, 2015 · 0 comments
Open

amp-add-class throws error with SVG elements in IE 10 #87

daver208 opened this issue Mar 6, 2015 · 0 comments

Comments

@daver208
Copy link

daver208 commented Mar 6, 2015

amp-add-class includes amp-has-class which appears to be based off of JQuery. When using amp-add-class on an SVGElement (or any object derived from one), the method hasClass() fails.

This because of the following line.
var cName = (isString(el) ? el : el.className).replace(whitespaceRE, ' ');
Once it sees that the element is an object it tries to use className which doesn't work for SVG Elements in IE10.

A workaround is to simply use element.classList.add('classname') and element.classList.remove('classname'). Again this was only tested in an IE 10 browser in a Windows 8 environment, testing in chrome and firefox

(edited 0516PM EST) "testing in chrome and firefox" did not have this issue, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants