Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract History and Router into independent modules. #33

Open
Prestaul opened this issue Mar 2, 2015 · 1 comment
Open

Extract History and Router into independent modules. #33

Prestaul opened this issue Mar 2, 2015 · 1 comment

Comments

@Prestaul
Copy link

Prestaul commented Mar 2, 2015

Is there a reason that I cannot use History without Router and visa versa? I'm curious is this was a design decision or just the result of the Backbone port. The current implementation prevents the router from being used outside of the browser.

Honestly, I'd love to see 3 modules:

  1. History/pushState - A client-side module that manages browser history for me and provides events for state change.
  2. Route matching and URL interpolation - Basically I want to map from a URL to a route and params, and from a route and params back to a URL. Could be used client-side or in node.
  3. The whole enchilada - A fancy facade that wraps these two together for me on the client. Basically what this module is today (plus url interpolation FTW).
@wraithgar
Copy link
Contributor

Yeah pretty sure this is just Backbone legacy that nobody's refactored yet.

This is essentially what we did with ampersand-subcollection, breaking it into its two constituents: filtering and pagination. We haven't refactored subcollection to use the new modules but it's in the works. It makes sense to do the same here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants