Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

editor drags the marked hint around #120

Open
takbal opened this issue Mar 9, 2021 · 1 comment
Open

editor drags the marked hint around #120

takbal opened this issue Mar 9, 2021 · 1 comment
Labels

Comments

@takbal
Copy link
Contributor

takbal commented Mar 9, 2021

While adding the StaticLint support, I could not fix this behaviour:

bug_dragging_error

The editor seems to drag the end of the marked text with the typing, but only when editing starts at the end of a marked text. The hints sent back from the julia code seem correctly positioned, and the positions are unchanged in subsequent updates (this can be also seen from that saving and opening the file fixes the problem), but the editor seems to override the messages.

I have put in a hack into julia-server.jl to mark one less character when the error is at the end of the buffer:

if endpos == length(code) # here length() should be changed to lastindex() for unicode
   endcolumn -= 1
end

so this is less of an issue when typing at the bottom of the file, but it is not an elegant solution. It does not help with insertions like on the screenshot either.

Not sure if I did something wrong, or it is a problem with linter.

@pfitzseb
Copy link

pfitzseb commented Mar 9, 2021

I'm pretty sure this is an upstream issue and commonly happens with Atom's decoration API. There's some code in ink that fixes the issue for inline results (which are another kind of decoration), so might make sense to upstream that.

@aminya aminya added the bug label Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants