Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Keys_Outgoing): Emit meaningful outgoing logs #6410

Closed
Tracked by #5606
LHerskind opened this issue May 15, 2024 · 0 comments · Fixed by #6560 · May be fixed by #6572
Closed
Tracked by #5606

feat(Keys_Outgoing): Emit meaningful outgoing logs #6410

LHerskind opened this issue May 15, 2024 · 0 comments · Fixed by #6560 · May be fixed by #6572
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented May 15, 2024

The currently emitted outgoing notes are not useful information.

We need to use the outgoing viewing key properly, and also implement in the note processor a way to handle the outgoing notes for us.

This can meaningfully be worked on when #6093 is addressed.

LHerskind added a commit that referenced this issue May 18, 2024
Fixes #5901. 

Uses the new format to match the keys and logs spec. The current
implementation here is still using a typescript implementation to
encrypt the data, mainly using the new flow.

The intention is that #6408 and #1139 can be addresses separately and
than we can just replace the import to use the constrained version
instead of the oracle at that point.

Note, that the outgoing logs are currently less than meaningful, as some
of the infrastructure is not yet in place to handle those nicely, see
#6410 for more on that.

What was called the encrypted_log_payload in #6348 have been moved into
the l1_payload, to better integrate with the rest of the setup.
benesjan added a commit that referenced this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants