Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aztec-nr: reconsider unconstrained wrappers of AvmContext #6420

Closed
fcarreiro opened this issue May 15, 2024 · 2 comments
Closed

aztec-nr: reconsider unconstrained wrappers of AvmContext #6420

fcarreiro opened this issue May 15, 2024 · 2 comments
Assignees
@fcarreiro
Labels
avm AVM related tickets (aka public VM)

Comments

@fcarreiro
Copy link
Contributor

These functions are, in principle, only called in an unconstrained environment, through the public/public-vm macro. However, they can only be called/mocked from pure (constrained) Noir from tests, like those in shared_mutable.nr. Therefore, we either have to wrap the oracles, or have everyone writing a test using the context have the test be unconstrained. We have opted for the former for better UX, for now.

We have to check if this emits internalcall-return opcodes wrapping the oracles. In that case, the blowup might justify unwrapping them.
@fcarreiro fcarreiro added the avm AVM related tickets (aka public VM) label May 15, 2024
@fcarreiro fcarreiro self-assigned this May 15, 2024
@fcarreiro fcarreiro mentioned this issue May 15, 2024
Merged
fcarreiro added a commit that referenced this issue May 15, 2024
@fcarreiro
chore(avm): wrap oracles with unconstrained fns (#6421)
3e7e094 
See #6420.
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue May 16, 2024
@fcarreiro @AztecBot
chore(avm): wrap oracles with unconstrained fns (#6421)
269a7fd 
See AztecProtocol/aztec-packages#6420.
@fcarreiro
Copy link
Contributor Author

fcarreiro commented May 16, 2024 •
edited

After adding this in #6449 I started getting Not enough L2GAS gas left in the avm simulator test, so it must be blowing up code.

@fcarreiro fcarreiro mentioned this issue May 16, 2024
Merged
fcarreiro added a commit that referenced this issue May 16, 2024
@fcarreiro
fix(avm-simulator): actually wrap oracles (#6449)
8685acc 
See #6420.
@fcarreiro
Copy link
Contributor Author

The blowup seems to have been fixed in noir-lang/noir#5121 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcarreiro fcarreiro

Labels
avm AVM related tickets (aka public VM)
Projects
A3
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fcarreiro