Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate usage of deprecated ServiceBus packages #10131

Open
jviau opened this issue May 8, 2024 · 0 comments
Open

Migrate usage of deprecated ServiceBus packages #10131

jviau opened this issue May 8, 2024 · 0 comments
Labels

Comments

@jviau
Copy link
Contributor

jviau commented May 8, 2024

Our tests use a deprecated service bus package:

<PackageReference Include="Microsoft.Azure.ServiceBus" Version="4.2.1" />

However, it also appears that the actual .cs files which use that are excluded from compile:

<Compile Remove="ScriptHostEndToEnd\ListenerFailureTests.cs" />
<Compile Remove="ServiceBus\ServiceBusEndToEndTestBase.cs" />
<Compile Remove="ServiceBus\ServiceBusTriggerCSharpEndToEndTests.cs" />
<Compile Remove="ServiceBus\ServiceBusTriggerNodeEndToEndTests.cs" />
<Compile Remove="Twilio\TwilioEndToEndTestsBase.cs" />

We should either migrate this package, fix the tests, and include them. Or remove the package and test files altogether.

@jviau jviau added the 1es 1 engineering system label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant