Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 #38

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

V1 #38

wants to merge 20 commits into from

Conversation

Rokt33r
Copy link
Member

@Rokt33r Rokt33r commented Mar 21, 2019

Fixes #22

  • Discard dependencies.
    • class-validator
    • class-transformer
    • class-transformer-validator
    • reflect-metadata
  • Disable validation of reqBody(It will be provided as a separated module).
  • Don't send if the res has already sent.
  • TBD...

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #38   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     26    -2     
  Lines         355    294   -61     
  Branches       35     34    -1     
=====================================
- Hits          355    294   -61
Impacted Files Coverage Δ
src/results/RedirectResult.ts 100% <100%> (ø) ⬆️
src/results/SendResult.ts 100% <100%> (ø) ⬆️
src/decorators/handlerParam/handlerParam.ts 100% <100%> (ø) ⬆️
src/results/SendStatusResult.ts 100% <100%> (ø) ⬆️
src/results/SendFileResult.ts 100% <100%> (ø) ⬆️
src/results/EndResult.ts 100% <100%> (ø) ⬆️
src/decorators/controller.ts 100% <100%> (ø) ⬆️
src/decorators/handlerParam/reqBody.ts 100% <100%> (ø) ⬆️
src/results/JSONResult.ts 100% <100%> (ø) ⬆️
src/BaseController.ts 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122120f...78156da. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified context
1 participant