Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make translator.save_xml relative to script not output_folder #121

Open
nllong opened this issue Apr 29, 2021 · 0 comments
Open

Make translator.save_xml relative to script not output_folder #121

nllong opened this issue Apr 29, 2021 · 0 comments
Assignees

Comments

@nllong
Copy link
Member

nllong commented Apr 29, 2021

When calling

translator.save_xml(File.join(save_file_name))

the results are stored relative to where you defined the output_folder as defined in the object instantiation.

translator = BuildingSync::Translator.new(xml_file, output_folder, epw_file_path)

If passing in a nonabsolute path, then IMO it should be relative to where you ran the script, not relative to the location of the object instantiation.

@nllong nllong self-assigned this Apr 29, 2021
@nllong nllong added this to Triage in BuildingSync 3.0 and Related via automation Apr 29, 2021
@nllong nllong moved this from Triage to To Do in BuildingSync 3.0 and Related May 14, 2021
@nllong nllong removed this from To Do in BuildingSync 3.0 and Related Oct 5, 2021
@nllong nllong added this to To do in FY22 - BuildingSync via automation Oct 5, 2021
@macintoshpie macintoshpie removed this from To do in FY22 - BuildingSync Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants