Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil @load_system error. #134

Open
lainsworth8801 opened this issue Sep 29, 2021 · 3 comments · May be fixed by #149
Open

Nil @load_system error. #134

lainsworth8801 opened this issue Sep 29, 2021 · 3 comments · May be fixed by #149
Assignees

Comments

@lainsworth8801
Copy link

lainsworth8801 commented Sep 29, 2021

An error "undefined method `add_internal_loads'" caused by a nil/empty @load_system.

BSync ver: v0.2.1;
EDV branch: rubocop;
Data: sf utility meter data (attached).
monthlyenergy_bricr_filtered.csv

Root cause:
@load_system is not assigned in facility.rb read_and_create_initial_systems for having a non-empty systems_xml.element.

Steps to repeat:

  1. save monthlyenergy_bricr_filtered.csv under <root_dir>/data/example;
  2. rake format_data[sf];
  3. rake generate_xmls;
  4. rake add_measured_data;
  5. rake generate_control_csv;
  6. rake simulate_batch_xml.

No simulation files generated in workflow_results/Simulation_Files directory.

@lainsworth8801
Copy link
Author

@JanghyunJK

@JanghyunJK
Copy link

@kflemin thanks for the tips!

based on my testing, this issue seemed to be solved with the change shown here: https://github.com/BuildingSync/BuildingSync-gem/compare/fix/134_load_system_error

I think I'm still getting another issue though. I'll see if I can track more and will post as an issue if necessary.

@haneslinger
Copy link
Contributor

#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants