Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small/med/large office classification based on incorrect unit #138

Open
JanghyunJK opened this issue Aug 2, 2022 · 1 comment
Open

small/med/large office classification based on incorrect unit #138

JanghyunJK opened this issue Aug 2, 2022 · 1 comment

Comments

@JanghyunJK
Copy link

just FYI and nothing posing risk on my end but if I'm looking at this right:

  • this json file includes simple floor area classification between small/med/large offices

  • so,

    • small office if total floor area < 20,000
    • med office if 20,000 < total floor area < 75,000
    • large office if total floor area > 75,000
  • and I think those 20,000 and 75,000 values were based on sqft and not m2

  • based on a small testing:

    • tested with two buildings: one with 10,000 sqft and the other with 25,000 sqft
    • when running the workflow through EDV workflow, I see output msg shown below:
Element ID: 2 started with occupancy_classification Office and total floor area: 929.0304000000001
selected the following standards_building_type: SmallOffice
Element ID: 4 started with occupancy_classification Office and total floor area: 2322.576
selected the following standards_building_type: SmallOffice
  • so looks like 10,000 was read as sqft (e.g., 10,000 sqft) and then converted to m2 (929 m2) (also confirmed this via OSM) but when small/med/large classification happened, it was using 20,000 and 75,000 as m2 for comparing against 929 and 2322.
@haneslinger
Copy link
Contributor

  • incoming xmls are assumed to be in sqft
  • the contexts of BUILDING_AND_SYSTEMS_FILE_PATH, which defines sub space types by size (here's an example), is assumed to be in sqft
  • openstudio is assumed to work in m2
  • The buildingsync gem converts incoming xmls sqft values to m2 upon the creation of the OS model generation

however BUILDING_AND_SYSTEMS_FILE_PATH is used exclusively by process_bldg_and_system_type, which assumes BUILDING_AND_SYSTEMS_FILE_PATH and the model are in the same units, which is untrue.

It's an easy fix. Just trying to figure out how to write the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants