Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeatingAndCoolingSystem (singular) as child of HeatingAndCoolingSystems #195

Open
corymosiman12 opened this issue Jul 13, 2020 · 2 comments

Comments

@corymosiman12
Copy link
Contributor

Under an auc:HVACSystem, there exists:

  • auc:Plants/HeatingPlants/HeatingPlant ... etc.
  • auc:DuctSystems/auc:DuctSystem
  • auc:OtherHVACSystems/auc:OtherHVACSystem

However, under auc:HeatingAndCoolingSystems, there is no singular child element. The intention is to add the following:

  • auc:HeatingAndCoolingSystems/auc:HeatingAndCoolingSystem

This would be a breaking change, but I believe makes sense from a consistency perspective.

@nllong @markborkum thoughts?

@markborkum
Copy link
Contributor

@corymosiman12 It would be a breaking change for Audit Template, which uses the auc:CoolingSources, auc:HeatingSources child elements.

@nllong
Copy link
Member

nllong commented Sep 30, 2020

What is the motivation for this change other than to add consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants