Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any node.js wizards want to lay out an initial project framework? #565

Open
amoffat opened this issue Jun 21, 2017 · 20 comments
Open

Any node.js wizards want to lay out an initial project framework? #565

amoffat opened this issue Jun 21, 2017 · 20 comments

Comments

@amoffat
Copy link
Contributor

amoffat commented Jun 21, 2017

I'm not experienced in node.js, so I was hoping to learn from some of you. Any node.js guys want to create a new repo and put down some scaffolding?

@andrewda
Copy link
Member

I can definitely work on that with someone

@PlasmaPower
Copy link
Contributor

I'm currently working on some other stuff, but I'll likely have some free time next week or earlier. I'd love to help then.

@andrewda
Copy link
Member

What do we want to call the repo? Are we going to be using any particular naming format?

@Redmega
Copy link

Redmega commented Jun 21, 2017

Count me in on the node team. This weekend I'll have some time to contribute

@mdcfe
Copy link
Contributor

mdcfe commented Jun 21, 2017

I'm currently busy, but I might be able to find some time to help.

@Swizz
Copy link
Member

Swizz commented Jun 21, 2017

JS dev here too.
I am lacking motivation in these past day. But I can be ready to go when the hype will be a ton motivational.

@Redmega
Copy link

Redmega commented Jun 21, 2017

We should call it chaos-node if it's to be the central node module.

@Swizz
Copy link
Member

Swizz commented Jun 21, 2017

@Chaosthebot/js-wizards team created 🎉

@rhengles
Copy link
Member

I'm currently busy, but I might be able to find some time to help.

^ This, also. I think it would help to have a overview of what needs to be implemented, since it would be hard for me to simply translate the Python source. Do we need a simple wrapper around node-github?

@Redmega
Copy link

Redmega commented Jun 21, 2017

I think the first step is to replicate the core democracy functionality and then expand after that. I'd imagine the Node core would be ideal for any sort of web server needs, api endpoints, mongo/couch/nosql integration, etc.

I'd also love for us to use graphql. I've been using it at work and it's just plain awesome.

@mdcfe
Copy link
Contributor

mdcfe commented Jun 21, 2017

@Redmega I'd much rather keep the critical code in the core (updating bot from git) and isolate other non-critical components (web server, PR handling, issue/project commands) to other processes - this project shows roughly how I thought functionality should be split.

@Redmega
Copy link

Redmega commented Jun 21, 2017

Let me stop using the word "Core" everywhere. Auto updating and restarting would be controlled by chaos-core. By "Core democracy functionality" I meant the PR voting, commands, etc. So in chaos-core we could specify that the democracy_module would point to chaos-node/democracy or something like that...

@mdcfe
Copy link
Contributor

mdcfe commented Jun 21, 2017

I've now created the Chaosthebot/Chaos-Core repo.

@Redmega It seems like the Node repo we're creating first is going to be the core, unless someone wants to write it in Python or another language instead. I don't necessarily think we should bundle together different parts of the bot in one repo per language.

@Redmega
Copy link

Redmega commented Jun 21, 2017

Maybe it might be better to separate via branch. Chaos-Core/master-node vs Chaos-Core/master-python?

@PlasmaPower
Copy link
Contributor

I don't think per branch is a good idea. Branches usually separate versions of the same code.

@andrewda
Copy link
Member

Yea if we are going to do different languages, it's got to be in different repos.

@mpnordland
Copy link

mpnordland commented Jun 22, 2017

So if we write this in nodejs, how do we plan to allow other modules (in Rust, Go, Python, etc) to launch and communicate?
@md678685 That link you have is 404'ing for me.

@mdcfe
Copy link
Contributor

mdcfe commented Jun 22, 2017

@mpnordland Child processes and IPC, but we'll need a standardised protocol for IPC and a format for knowing how to launch them. I've fixed the link.

@Redmega
Copy link

Redmega commented Jun 22, 2017

Maybe a modules.json which can be read to register modules map them to repos/endpoints/what-have-you.

@Redmega
Copy link

Redmega commented Jun 23, 2017

Maybe we can use something like forever-monitor to facilitate this.

@Chaosthebot Chaosthebot deleted a comment Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment from andrewda Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment from PlasmaPower Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment from PlasmaPower Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment from amoffat Jun 28, 2017
@Chaosthebot Chaosthebot deleted a comment from PlasmaPower Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants