Initial commit to add automatic pool sizing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft, still encountering issues in prod in openflight, so its not perfect and ready for use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well ive tried my best to cover all edge cases, even though it is still possible for it to miss auto sizing.
closes #14
closes #12
It will check the pool size if you look at the inspector, focus the SDK, or have a script rebuild / import. This should hopefully cover enough things that its not an issue over the long run. The only thing it does not cover is if the user changes the world size through the SDK and saves it, then immediately builds. This is because without using harmony to edit those methods theres not really anything to hook onto to detect that change unfortunately. I also realize this code is a bit..... jank, so if you have any ideas on how to clean it up or want to remove things let me know