Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for include_past #46

Open
nicholasxwang opened this issue May 14, 2022 · 14 comments
Open

No support for include_past #46

nicholasxwang opened this issue May 14, 2022 · 14 comments

Comments

@nicholasxwang
Copy link

Support for include_past for https://developers.schoology.com/api-documentation/rest-api-v1/course-section in section-related endpoints is missing.

@nicholasxwang
Copy link
Author

Screen Shot 2022-05-14 at 2 49 54 PM

This works and is a good work around but native support is still perferred.

@ErikBoesen
Copy link
Owner

Thanks for pointing this out!

@nicholasxwang
Copy link
Author

No problem!

@ErikBoesen
Copy link
Owner

@nicholasxwang I just pushed a fix for this. I'm not able to test on my own machine as I no longer have access to any Schoology instance; do you mind cloning to your machine, installing with pip install -e . and testing out your use case and the example scripts to verify there are no errors? Thank you!

@nicholasxwang
Copy link
Author

Alright! Thanks! I'll try it out as soon as I have time. (Probably tomorrow)

@ErikBoesen
Copy link
Owner

Have you had a moment to try it out?

@nicholasxwang
Copy link
Author

Screen Shot 2022-05-21 at 12 19 20 PM

Here ^

@ErikBoesen
Copy link
Owner

What Python version are you using? Run python --version.

@nicholasxwang
Copy link
Author

Oops! I just realized Im using python2. One sec...I'm fighting installation errors.

@nicholasxwang
Copy link
Author

I keep getting Traceback (most recent call last): File "/Users/NicholasWang/schoolopy/example-threelegged.py", line 5, in <module> with open('example_config.yml', 'r') as f: FileNotFoundError: [Errno 2] No such file or directory: 'example_config.yml'

@ErikBoesen
Copy link
Owner

That would happen if you haven't created the example_config.yml file with your credentials. Could you create one with your API key/token and try running the two legged example?

@nicholasxwang
Copy link
Author

Alright. I can try Thursday evening. I have a lot of work today and tomorrow. Sorry

@ErikBoesen
Copy link
Owner

No worries! @nicholasxwang Good luck!

@ErikBoesen
Copy link
Owner

Were you able to try this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants