Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out manual avatar entry #197

Open
ErikBoesen opened this issue Aug 16, 2019 · 2 comments
Open

Phase out manual avatar entry #197

ErikBoesen opened this issue Aug 16, 2019 · 2 comments

Comments

@ErikBoesen
Copy link
Member

After seeing #196, I realized it might be a good idea to totally phase out the process of manually PR-ing avatars into this repository since FIRST maintains avatars themselves now which are often just as good quality if not better. It might help if we could get a count of how many teams who have submitted avatars to this repo also have official FIRST avatars—my guess is that most teams who've submitted here have submitted more professional official avatars. If only they'd stop submitting black or white backgrounds.

@EthShaw
Copy link
Member

EthShaw commented Aug 17, 2019

I just did some tests:

152/188 (~81%) teams with manually submitted avatars also have a FIRST avatar, which means
36/188 (~19%) do not.

I threw together a comparison of the avatars of teams that have both manually submitted logos and official FIRST avatars here. Manually submitted avatars are on the left, official FIRST avatars are on the right. A lot of teams' official FIRST avatars do seem to be better / higher quality than their uploaded avatars, though some do have added black/white backgrounds in their official FIRST avatars.

@ErikBoesen
Copy link
Member Author

@FishDog5000 I'm entering college and will likely have very little time to look into this, so do whatever you think is best! :)

EthShaw added a commit to EthShaw/firstmap.github.io that referenced this issue Sep 7, 2019
* Remove all logos of teams that already have official FIRST avatars.
* Default to using FIRST avatar instead of manually submitted avatars.
* Update README to explain the removal of manual avatar submission.

Progress towards FIRSTMap#197
EthShaw added a commit to EthShaw/firstmap.github.io that referenced this issue Sep 7, 2019
* Remove all logos of teams that already have official FIRST avatars.
* Default to using FIRST avatar instead of manually submitted avatars.
* Update README to explain the removal of manual avatar submission.

Progress towards FIRSTMap#197
ErikBoesen pushed a commit that referenced this issue Sep 8, 2019
* Remove all logos of teams that already have official FIRST avatars.
* Default to using FIRST avatar instead of manually submitted avatars.
* Update README to explain the removal of manual avatar submission.

Progress towards #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants