Removed problematic exception handling.

RillingDev · Jun 18, 2023 · 916a5bc · 916a5bc
1 parent 495d955
commit 916a5bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherApplication.java b/src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherApplication.java
@@ -1,6 +1,5 @@
 package dev.rilling.musicbrainzenricher;
 
-import dev.rilling.musicbrainzenricher.api.musicbrainz.MusicbrainzEditController;
 import dev.rilling.musicbrainzenricher.core.DataType;
 import org.jetbrains.annotations.NotNull;
 import org.slf4j.Logger;
@@ -19,14 +18,10 @@ public class MusicbrainzEnricherApplication implements CommandLineRunner {
 	private static final Logger LOGGER = LoggerFactory.getLogger(MusicbrainzEnricherApplication.class);
 
 	private final MusicbrainzEnricherService musicbrainzEnricherService;
-	private final MusicbrainzEditController musicbrainzEditController;
 	private final ExecutorService enrichmentExecutor;
 
-	MusicbrainzEnricherApplication(MusicbrainzEnricherService musicbrainzEnricherService,
-								   MusicbrainzEditController musicbrainzEditController,
-								   @Qualifier("enrichmentExecutor") ExecutorService enrichmentExecutor) {
+	MusicbrainzEnricherApplication(MusicbrainzEnricherService musicbrainzEnricherService, @Qualifier("enrichmentExecutor") ExecutorService enrichmentExecutor) {
 		this.musicbrainzEnricherService = musicbrainzEnricherService;
-		this.musicbrainzEditController = musicbrainzEditController;
 		this.enrichmentExecutor = enrichmentExecutor;
 	}
 

diff --git a/src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherService.java b/src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherService.java
@@ -48,13 +48,7 @@ public void runInSingleMode(@NotNull DataType dataType, @NotNull UUID mbid) {
 
 	private void executeEnrichment(@NotNull DataType dataType, @NotNull UUID mbid, AbstractEnrichmentService<?, ?> enrichmentService) {
 		LOGGER.info("Starting enrichment for {} '{}'.", dataType, mbid);
-		try {
-			enrichmentService.executeEnrichment(mbid);
-		} catch (RuntimeException e) {
-			LOGGER.error("Could not enrich {} '{}'.", dataType, mbid, e);
-			return;
-		}
-		// TODO: should not persist if submission was not flushed yet.
+		enrichmentService.executeEnrichment(mbid);
 		LOGGER.info("Completed enrichment for {} '{}'.", dataType, mbid);
 		historyService.markAsChecked(dataType, mbid);
 	}