-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Thumbs Being Visible #4
Comments
So I started working on this, I should have something soon. |
Awesome, made any progress since your post? |
Sorry, got busy and forgot about this. Before I forgot though, I did somewhat implement it. The issue I have now is it doesn't dynamically change. The application needs to be restarted to have the thumbs and shuffle/repeat buttons switched. Once I figure that out I'll request a pull request. |
That's great! Don't you have to restart the application to change some other settings anyway? I'd be pretty happy with that implementation. Just put "(requires application restart)" after the checkbox and description? |
Yea for some things it does require restart, I guess I could do that indeed. Let me just clean up the code, and merge in the latest changes. |
Nice one! |
@bpclarke @Lettuceman44 Requiring a user restart is only on ONE setting and that is a core OS level API limitation. A user should not have to restart the player to shows some thumbs 😢 I've left a comment explaining how to do this without restarting |
Understood, will get that changed. |
Just as a quick update as I've been busy, I have it so it switches from the shuffle/repeat to thumbs dynamically without restarting, that wasn't hard at all, just copy paste :P. It doesn't work vice versa though, and I haven't figured it out yet. Unfortunately for me, I haven't had any internet this week, waiting for that to get fixed as well. |
I love everything about GPMDP but one of the larger annoyances is a lack of thumbs up/thumbs down in the miniplayer.
Google moves the shuffle and repeat icons outside of the bar in their version.
For reference
GPMDP:
Google's Official Chrome App:
GPMDP does show thumbs when listening to the radio.
We discussed some options here to toggle this view by default potentially.
The text was updated successfully, but these errors were encountered: