Copy to Clipboard Button #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
requested changes
May 21, 2024
assets/main.js
Outdated
|
|
||
| document.addEventListener("DOMContentLoaded", function () { | ||
| const copyBtns = document.querySelectorAll(".copy-btn"); | ||
| copyBtns.forEach((btn) => { |
There was a problem hiding this comment.
Suggested change
| copyBtns.forEach((btn) => { | |
| document.querySelectorAll(".copy-btn").forEach((btn) => { |
Pretty minor thing, but I guess we can loop directly here?
| @@ -9,5 +9,10 @@ | |||
| Schema</span> | |||
| </div> | |||
| {{ $code := trim .Inner "\n" }} | |||
| {{ transform.Highlight ($code) "json" }} | |||
| <div class="position-relative"> | |||
There was a problem hiding this comment.
Works great, but I think this wrapper is messing things up a bit. Check the dark gray top and bottom borders compared to the ones in the live website:
I think its because of some CSS rules trying to match .hightlight directly under code. Can you please revise those rules a little bit?
|
Fixed it! |
jviotti
reviewed
May 21, 2024
jviotti
approved these changes
May 21, 2024
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
2024-05-20.22-34-58.mp4