Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transaction export option? #25

Open
JAForbes opened this issue Feb 20, 2023 · 0 comments
Open

Remove transaction export option? #25

JAForbes opened this issue Feb 20, 2023 · 0 comments
Labels

Comments

@JAForbes
Copy link
Owner

The more migrations I do the more I find I don't use the transaction option because I frequently am using SQL statements that cannot be run in a transaction.

And the drop owned by auto teardown works so well in development that atomicity isn't really needed.

So I'm thinking instead of dropping support for export const transaction and only supporting export const action and as there's only one type of operation at that point, action can just be export default as well.

If a user wants a transaction they can just use sql.begin, which we can document and then refer to postgres.js docs

@JAForbes JAForbes added the idea label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant