Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli works but crashes at the end #70

Open
dangelov opened this issue Mar 21, 2020 · 5 comments · Fixed by #76
Open

cli works but crashes at the end #70

dangelov opened this issue Mar 21, 2020 · 5 comments · Fixed by #76

Comments

@dangelov
Copy link

After running trimage with:
trimage -d .

It seems to successfully process all files, but ends with a crash:

Exception ignored in: <function Worker.__del__ at 0x7fd26857d9d0>
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/trimage/trimage.py", line 414, in __del__
  File "/usr/lib/python3.8/site-packages/trimage/ThreadPool/ThreadPool.py", line 172, in shutdown
TypeError: 'NoneType' object is not callable

Running the newest version, installed with yay -S trimage on Arch Linux.

@orende
Copy link

orende commented Nov 1, 2020

Can confirm, this is happening to me as well with trimage 1.0.6 and Python 3.8.5 on Ubuntu 20.04.1 LTS.

@diklimchuk
Copy link

I had the same issue, worked after buidling trimage from sources. This issue was fixed in #76 so it probably can be closed now.

@orende
Copy link

orende commented Nov 24, 2020

@diklimchuk The current version in the Ubuntu package repo is 1.0.6, which was released before the fix. So anyone installing from there will still experience the issue.

@rootwork
Copy link

Can we get a new release for Ubuntu?

Incidentally the "Download for Ubuntu" link on trimage.org is now broken; it gets redirected to snapcraft.io, and Trimage isn't there. (apt install still works)

@rootwork
Copy link

Oh, and it's confusing because when building from source, the version reported is still 1.0.6 -- would be helpful to get a version bump too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants