Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we pin against a specific Node version? #1222

Open
glasserc opened this issue Jan 13, 2020 · 0 comments
Open

Should we pin against a specific Node version? #1222

glasserc opened this issue Jan 13, 2020 · 0 comments
Labels

Comments

@glasserc
Copy link
Contributor

nodejs/node@3e0709cf5e landed in Node v10.8.1. We pin to Node v10 but not with any more specificity than that. This broke a test. The fix is easy but it raises the question of whether we should pin the Node version more tightly so that these changes are at least made explicit.

My personal opinion could go either way on this. It was a minor, cosmetic feature that broke and the tests caught it. On the other hand, we do have control over what version of Node we are using and we could justifiably pin the CI to whatever we use in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant