Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an integration test with kinto #1582

Open
dstaley opened this issue Nov 2, 2020 · 2 comments
Open

Create an integration test with kinto #1582

dstaley opened this issue Nov 2, 2020 · 2 comments
Assignees

Comments

@dstaley
Copy link
Member

dstaley commented Nov 2, 2020

We should create an integration test that confirms the master branch of kinto can build the admin with the PR. It should test that the admin builds, and that it loads correctly in a browser.

@dstaley dstaley self-assigned this Nov 2, 2020
@leplatrem
Copy link
Contributor

We have something similar in kinto-dist: https://github.com/mozilla-services/kinto-dist/blob/9f8094f84b6241621712a18ec201465cf9dead21/tests/test_integration.py#L23-L28
but in the particular case of Kinto/kinto#2646 it didn't detect the error after submitting the login form..

@alexcottner
Copy link
Contributor

We're kinda doing this now, or at least I think we've got the spirit of it.

We have the browser test that will run against the latest kinto-admin release for each PR. (recent example)

For ensuring the build process works, we have CI checks on each PR (example) and a single-server admin build is automatically attached to each release. See the current release and the action log as examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants