Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uploading a new file, properties fail to be cleared/removed #3129

Open
alexcottner opened this issue Jan 17, 2024 · 3 comments
Open

When uploading a new file, properties fail to be cleared/removed #3129

alexcottner opened this issue Jan 17, 2024 · 3 comments
Labels

Comments

@alexcottner
Copy link
Contributor

See attached video.

  1. Edit an existing record on a collection that supports file attachments
  2. Clear out a property
  3. Attach a new file
  4. Click update
  5. Note that the property you tried to clear has the old value in it

If you change the property to something else, it will change as expected. Only trying to set it to blank/undefined causes this issue.

remote-settings-update-2.mp4
@alexcottner
Copy link
Contributor Author

Suggested workaround for now - delete old record and create new one while we work on a solution. This looks like it will require changes in both kinto-admin and kinto-attachment or kinto.

@leplatrem
Copy link
Contributor

Why not clear the property without attaching a new file?
(It could be done in two steps...)

Unless we introduced a regression, it should be possible to edit attributes without having to attach a file if the record has already one

@alexcottner
Copy link
Contributor Author

That is a separate bug that I opened and has been fixed. This one is a little more complicated because it probably involves changing a couple things, and might cause our UI and kinto-attachment versions to become connected for a few releases.

But also, hopefully this issue is much rarer with us fixing the other bug and we can make it a lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants