Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test this package against all the tests of the original Immutable.js #4

Open
kirillrogovoy opened this issue Sep 12, 2016 · 2 comments

Comments

@kirillrogovoy
Copy link

Hi!

I think, such proxying libraries should be required to be tested against the original tests of what you're actually trapping as the ultimate way of setting up some trust towards the project at whole.

I guess, there should be a way to do it without much of effort, but it will prove a stability and a robustness in a great way. It's also sort of an interesting challenge. :)

@zackify
Copy link
Member

zackify commented Sep 12, 2016

If you are up for contributing I will try my best to help, just don't have a lot of time to commit to this.

@igorsantos07
Copy link

igorsantos07 commented Nov 6, 2016

I would suggest you so to state that clearly on the readme, @zackify :)
The project already got 18 stars, but it only half-works (given what happens when you use the library in real projects, as sampled on #5).

This project seems to be just a (flawed) proof of concept that is being considered as something, given the catchy name. i.e. it was mentioned on a real feature request about Proxies on Immutable as a valid suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants