Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The appdmg@0.6.6 fails to install on systems with python3 v3.12.0 #234

Open
jozefizso opened this issue Oct 28, 2023 · 7 comments
Open

The appdmg@0.6.6 fails to install on systems with python3 v3.12.0 #234

jozefizso opened this issue Oct 28, 2023 · 7 comments

Comments

@jozefizso
Copy link

We see failures to install the appdmg@0.6.6 on systems running python3 v3.12.0. It can install correctly with python 3.11.0.

See https://github.com/jozefizso/macosrunner-appdmg/actions/runs/6676439380

@tk-nguyen
Copy link

tk-nguyen commented Nov 3, 2023

Related to this node-gyp issue: nodejs/node-gyp#2869.

It's because distutils is removed from Python 3.12, see https://docs.python.org/dev/whatsnew/3.12.html#distutils for more details. The default python3 on macos-latest/macos-12 is python 3.12.0 (Same with macos-11 and macos-13).

For a workaround, install setuptools through pip:

python3 -m pip install setuptools

@BoykoAlex
Copy link

We are also interested in seeing this fixed asap :-)

@jozefizso
Copy link
Author

@BoykoAlex if you need fix ASAP I would advise you to write the fix and provide PR.

@BoykoAlex
Copy link

Well... the workaround helped so not ASAP ;-)

@GitMurf
Copy link

GitMurf commented Nov 12, 2023

Thanks @tk-nguyen for the setup tools workaround! It worked for me :)

@AlexanderOMara
Copy link

The silent failure to install when using optionalDependencies can make this hard to track down.

Adding node-gyp (^10.0.1 in my case) as a dependency also seems to resolve the issue.

@jozefizso
Copy link
Author

We fixed this in our GitHub Actions workflows running on macos-14-xlarge like this;

- name: setup python
  uses: actions/setup-python@v5
  with:
    python-version: 3.12

- name: setup appdmg
  run: |
    python3 -m pip install setuptools
    npm install -g appdmg@0.6.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants