Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fn + F5 / F6 / F7 (previous song, pause, next song) buttons have stopped working #3920

Open
3 tasks done
krevs opened this issue Mar 3, 2021 · 48 comments
Open
3 tasks done

Comments

@krevs
Copy link

krevs commented Mar 3, 2021

Checklist:

OS: Windows

GPMDP Version: 4.7.1

Issue Descriptions: Fn + F5 / F6 / F7 (previous song, pause, next song) buttons have stopped working

Steps to Reproduce:

@cruzzer
Copy link

cruzzer commented Mar 3, 2021

I'm seeing a similar issue on Windows and MacOS, where the media keys no longer work.

@xc-racer
Copy link

xc-racer commented Mar 3, 2021

Similar issue as of this morning.
Play/Pause, Previous Track & Next Track keys on my Logitech K330 keyboard have stopped working.

OS - Windows 10 Home version 1909
GPMDP Version - 4.7.1

Edit:
Just did a bit more digging - media keys work fine in VLC and iTunes.
Also work fine for music.youtube.com when opened in Microsoft Edge.
But, they're not working for youtube.com or music.youtube.com when opened in Chrome.
So it looks like it's a Chrome issue?

@stick1300
Copy link

Yup, noticed this late yesterday. I've got the previous/next/pause commands mapped to custom keys (SHIFT+CTRL+I/O/P).

OS - Windows 10 Pro 19041.572
GPMDP version - 4.7.1

@ITguy13
Copy link

ITguy13 commented Mar 3, 2021

I can confirm it's happening as well. None of my hotkeys that have worked for years have stopped working. I used a hotkey detective to confirm that GPMDP is still the only app that they are mapped to. I also wiped out my AppData for GPMDP to reset it and no luck.

OS - Windows 10 Pro 20H2 (19042.804)
GPMDP - 4.7.1

@cfsmp3
Copy link

cfsmp3 commented Mar 4, 2021

Actually it's not the keys. I've spent a few hours tracking this down (linux) trying to figure out if there was any program hijacking the keys, but no.

If you use the same options on the menu they don't work either. Strange, as "Show" for example works as expected, as well as the rest of the menu (quit, help, etc).

I suspect the problem is not with GPMDP but some change from Google breaking things.

@weaseldotro
Copy link

Pause, next and previous track keys have stopped working when using this player on my machine with Ubuntu 20.04.

@bruno-brant
Copy link

Same here - I configure personal hotkeys like CTRL+ALT+C and CTRL+ALT+V and they simply stopped working, out of the blue. Also my Logitech headset media keys.

I restarted Windows a couple of times to see if GPMDP was able to register the keys and tried to check if any other program was hijacking those keys but I concluded that this is something with GPMDP itself. I now certain of it because of this thread - people on different systems having similar trouble.

Is there a log that I could look at? Although, I'd say that GPMDP is oblivious to the issue, since usually it complains right after I set the key, and this isn't the case.

@bruno-brant
Copy link

Reflecting on the issue (without looking at the code) I expect that something changed on YT side of things because:

  • It's started without any changes to GPMDP itself.
  • It's affecting people on all kind of OSes.
  • GPMDP isn't complaining when registering keys, it's just not doing what it's supposed to do once we actuate those keys.

UPDATE: Right clicking the taskbar icon and selecting Play/Pause doesn't work either, which confirms my assumptions.

image

@bruno-brant
Copy link

bruno-brant commented Mar 4, 2021

I think I tracked down the issue. The culprit is actually an upstream project, (ytmusic.js)[gmusic-utils/ytmusic.js]. GPMDP relies on it to control playback on YT music. I believe its selector might be failing o click the button. If I'm not mistaken, the selectors are here. For play/pause for instance, they are:

  playPause: '.left-controls .play-pause-button',

And while I can't attest to what was before, this selector returns null: Nope, it doesn't, I inverted the classes in the query below!

image

While using just .play-pause-button' might be enough:

image

(this last snippet will start/stop playing in YT Music)

@jostrander
Copy link
Collaborator

jostrander commented Mar 4, 2021

Appears to be related to track progress, investigating further.

image

The track progress element was recently changed to tp-yt-paper-slider. Unfortunately the underlying library is throwing an assertion error because it can't map the progress selector correctly, which ends the further results of the lib.

@FinchPowers
Copy link

FinchPowers commented Mar 4, 2021

In the meantime, it seems like the command keys are working in the browser version at https://music.youtube.com/. (I've tried with Firefox.)

@xc-racer
Copy link

xc-racer commented Mar 4, 2021

@FinchPowers
My observation is that command keys are working in the browser version of music.youtube.com when opened in Microsoft Edge, but NOT in Chrome.

@HudsonAfonso
Copy link

20210304_050149-CapturFiles

@cruzzer
Copy link

cruzzer commented Mar 8, 2021

Does this mean that the issue has been fixed upstream and now needs to be compiled into a new release of GPMDP?

@agzam
Copy link

agzam commented Mar 8, 2021

Any news on this issue?

This is so infuriatingly frustrating. I've got a paid account for Google Music, for which Google has never built a native player, nor ever tried to support this one; or at least ever attempted to make sure not to break things. So many times I had to deal with their temper-tantrums. And so many times I would get frustrated, yet keep using Google Music, which is now YouTube Music. And since it became YT Music, I can't no longer even watch YT videos and listen to the music at the same time. On the same laptop. Seriously? WTF, Google?

Honestly, I feel guilty for using anything from Google these days, and even more so for paying for its services.
Google not even trying to hide it anymore, they are not on the trajectory to become evil - they already are evil.

Sometimes I feel so depressed and helpless for not being able to say: "Go to Hell, Google! Go to Hell with all your shit!". Using anything of Google these days feels like smoking cigarettes in front of your kids - gross, stupid and inconsiderate. I wouldn't even get surprised if at some point people organize "support groups", similar to AA, where they'd be helping each other to stay off Google products. "Wohoo! Today I got another star for not using Gmail for six months straight. I'm doing it, folks! I am free!"...

@cfsmp3
Copy link

cfsmp3 commented Mar 8, 2021

Any news on this issue? This is so infuriatingly frustrating. I've got a paid account for Google Music, for which Google has

You realize that is project has nothing to do with Google, right :-)
It seems to be an abandoned project, so it's up to the community to fork and maintain it.
I tried that fix and it didn't work for me, but maybe I was having a bad idea and didn't do it right, or I had some other problem as well.

What specific OS are you using?

@agzam
Copy link

agzam commented Mar 8, 2021

You realize that is project has nothing to do with Google, right :-)

Oh, of course I am. I apologize for that it sounded like I'm complaining about the project. No. I completely understand that this issue is upstream and like it happened many times before - it is due to Google's BS.

I am not frustrated with this App. I love it. I should've probably emphasized that. I just assumed everyone who uses GPMDP knows that this issue is not internal.

What specific OS are you using?

OS X Big Sur

@DanRxn
Copy link

DanRxn commented Mar 9, 2021

For whatever it's worth, the menu command, Edit > Previous Page, is not working for me, to go back to the previous screen. Neither is the keyboard shortcut for the same command:

Cmd + [

Feels like this has broken basically at the same time I noticed the media keys (play, pause, skip, etc.) not working. Just mentioning in case that helps anyone have a better sense of where this may be breaking. Even if not helpful, hopefully this will get fixed along with the media keys...

🤞😬

@bruno-brant
Copy link

@DanRxn same here. I was about to post about it - I use mouse keys for back/forward and they stopped working. Alt+→ or Alt+← also don't work. Probably it's all related.

@trobrock
Copy link

Does anyone know what needs to be done in the code to get this working again? It crazy annoying and I'm happy to dedicate some time today to fixing it if I could be pointed in the right direction (if there is even anything we can do within this project).

@cruzzer
Copy link

cruzzer commented Mar 16, 2021

Does anyone know what needs to be done in the code to get this working again? It crazy annoying and I'm happy to dedicate some time today to fixing it if I could be pointed in the right direction (if there is even anything we can do within this project).

There appears to have been a google side change which the player hooked into. In @bruno-brant comment, he mentions an upstream project which is used by GPMDP to control ytmusic.

In a linked ytmusic.js issue, they mentioned that they've fixed an issue on their side and comment that GPMDP will need to pull their change. You might just need to build GPMDP with their changes.

@SlashmanX
Copy link

Does anyone know what needs to be done in the code to get this working again? It crazy annoying and I'm happy to dedicate some time today to fixing it if I could be pointed in the right direction (if there is even anything we can do within this project).

#3922 just needs to get merged

@bruno-brant
Copy link

Everyone coming here for this fix: you can get a pre-release from AppVeyor (either go here https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/38077585/artifacts or follow the link in the PR #3922).

This is a work around while said PR isn't merged.

@cfsmp3
Copy link

cfsmp3 commented Mar 16, 2021

Ultimately I switched to Youtube Music Desktop which is maintained and I'd say pretty much the same thing (and it works).

@agzam
Copy link

agzam commented Mar 16, 2021

@cfsmp3 Nope. This feature - Multimedia keys (Previous, Next, Pause, etc.) currently broken in ytmdesktop-youtube-music app as well.

@YellowGTO
Copy link

Ultimately I switched to Youtube Music Desktop which is maintained and I'd say pretty much the same thing (and it works).

Same. For anyone else, if you navigate to music.youtube.com with chrome, near the chromecast button it will ask you to install the desktop app.

@cfsmp3
Copy link

cfsmp3 commented Mar 16, 2021 via email

@agzam
Copy link

agzam commented Mar 16, 2021

if you navigate to music.youtube.com with chrome, near the chromecast button it will ask you to install the desktop app.

That thing has never worked for me. It just hangs. It hangs both itself and the browser. Tried with Chrome and Brave - same results. Probably has something to do with OS X Big Sur settings. Fuck you Google! and Fuck you Apple! (you ain't no better)

@tconley
Copy link

tconley commented Mar 17, 2021

i had to switch to youtube desktop music to get my shortcut keys working :(

@martinduparc
Copy link

Here is a macOS build with the updated ytmusic.js
https://www.dropbox.com/s/8wg2lrlxjnwd9r0/Google%20Play%20Music%20Desktop%20Player.zip

@cruzzer
Copy link

cruzzer commented Mar 17, 2021

Everyone coming here for this fix: you can get a pre-release from AppVeyor (either go here https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/38077585/artifacts or follow the link in the PR #3922).

This is a work around while said PR isn't merged.

Can confirm that this worked for me on Windows 10. Media keys are working again. Thank you.

Can also confirm that the program referenced by @cfsmp3, Youtube Music Desktop worked for me. I had not heard of it before. As probably most, I searched for a desktop player when I first got Google Music and have stuck with GPMDP ever since.

@phuertay
Copy link

Everyone coming here for this fix: you can get a pre-release from AppVeyor (either go here https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/38077585/artifacts or follow the link in the PR #3922).

This is a work around while said PR isn't merged.

This fixed the issue for me, thanks so much!!!! ( ゚Д゚)b

@DanDobrick
Copy link

Here is a macOS build with the updated ytmusic.js
https://www.dropbox.com/s/8wg2lrlxjnwd9r0/Google%20Play%20Music%20Desktop%20Player.zip

This build works perfectly, thanks so much!

@cruzzer
Copy link

cruzzer commented Mar 18, 2021

On Tue, Mar 16, 2021 at 3:54 PM Ag Ibragimov @.***> wrote: @cfsmp3 https://github.com/cfsmp3 Nope. This feature - Multimedia keys (Previous, Next, Pause, etc.) currently broken in ytmdesktop-youtube-music app as well.
I'm using them just fine.

I had confirmed that it worked for me on Windows 10.
Today I tested and could not get it to work with MacOS. I tried various versions. Maybe someone had more luck with MacOS.

@agzam
Copy link

agzam commented Mar 18, 2021

This build works perfectly, thanks so much!

Fuck, yeah! I love you guys! Thank you for saving me from this misery. It's been extremely annoying without it.

@jgspratt
Copy link

jgspratt commented Apr 1, 2021

That dropbox link is no longer a .zip. Can you please upload another? I need a copy.

Edit: Ignore me. You can't right-click -> download. Left click it and follow the menu.

@jgspratt
Copy link

jgspratt commented Apr 1, 2021

I can confirm the dropbox build above works. I had a session open so long that it only today exhibited this issue.

@lbarnes-cs
Copy link

Here is a macOS build with the updated ytmusic.js
https://www.dropbox.com/s/8wg2lrlxjnwd9r0/Google%20Play%20Music%20Desktop%20Player.zip

Tested on MacOS (Big Sur 11.2.3) and confirmed that it works with the media keys. Cannot express my gratitude enough. Thank you!!

@elfbread420
Copy link

elfbread420 commented Apr 19, 2021

Everyone coming here for this fix: you can get a pre-release from AppVeyor (either go here https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/38077585/artifacts or follow the link in the PR #3922).

This is a work around while said PR isn't merged.

This did work for me, but not on my new computer. The windows 10 media overlay shows up for me, but with no Track playing. The Youtube Music app (installed through Chrome) works now, but unfortunately you can't have your Chrome and Youtube Music app logged into separate accounts. Very annoying.

Any suggestions beyond just using a different browser for YouTube (what I'm doing now)?

Edit: Spoke too soon, only pausing works. Even unpausing doesn't work.

@agarzola
Copy link

The build shared by @martinduparc worked for me on my older laptop running macOS Big Sur, but I just got my hands on a new Air (with the M1 processor, which may or may not be relevant) and I’m once again having this media keys issue. I also have some custom hot keys configured (which also used to work on my old laptop running Big Sur with the fixed build linked above) and they too fail to work as expected.

I’ve granted the app both Accessibility and Input Monitoring privileges in the Security & Privacy section of system settings, but these do not appear to have any effect.

@gfogus
Copy link

gfogus commented May 10, 2021

@agarzola Yep. Mine stopped working today also on a Mac system that was previously working after the fix.

@jgspratt
Copy link

Same here on macOS 10.15.7. It suddenly just stopped working. The fix from @martinduparc had been working for a few weeks but has now stopped working.

@HBBisenieks
Copy link

Actually it's not the keys. I've spent a few hours tracking this down (linux) trying to figure out if there was any program hijacking the keys, but no.

If you use the same options on the menu they don't work either. Strange, as "Show" for example works as expected, as well as the rest of the menu (quit, help, etc).

I suspect the problem is not with GPMDP but some change from Google breaking things.

I can confirm that this is the case on MacOS 11.2 and 11.3. Media keys, tray icon controls, and touchbar controls all don't function, which is a drag and a half.

@agarzola
Copy link

This issue appears to have resolved itself! Can’t be sure when it was fixed, but I noticed it just now. Media keys, custom hot keys, and the menu bar submenu, all work for me on macOS Big Sur without having updated anything. I suggest others in this thread refresh the player and try their media keys and custom hot keys to confirm.

@alexander-narbut
Copy link

alexander-narbut commented May 29, 2021

The only reason I use GPMDP is hotkeys and they're not working.
Tried to completely reinstall + remove the folder from %AppData%, nothing helps, Windows 10 19042.985.

@agzam
Copy link

agzam commented Jul 18, 2021

Damn it. Has Google made some changes again that have broken the multimedia keys in the app? Again... sigh

@alexventuraio
Copy link

Here is a macOS build with the updated ytmusic.js
https://www.dropbox.com/s/8wg2lrlxjnwd9r0/Google%20Play%20Music%20Desktop%20Player.zip

Can anyone share this build, plase?
The file seems to be delted.

@bruno-brant
Copy link

Can anyone share this build, plase?
The file seems to be delted.

Hey @alexventuraio I suggest you look into YT Music Desktop (https://ytmdesktop.app) since it is still being maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests