Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom elements: built-in element extensions lose their is attribute #2799

Open
barneycarroll opened this issue Sep 5, 2022 · 1 comment
Open

Custom elements: built-in element extensions lose their is attribute #2799

barneycarroll opened this issue Sep 5, 2022 · 1 comment
Assignees
@barneycarroll
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@barneycarroll
Copy link
Member

As demonstrated here, a custom element that extends a built-in via the is attribute behaves strangely. The extension is recognised and the custom element is constructed as expected; but the is attribute that determined this behaviour is not present on the rendered element. Having been specified in hyperscript, I would expect it to remain.
@barneycarroll barneycarroll added the Type: Bug For bugs and any other unexpected breakage label Sep 5, 2022
@barneycarroll barneycarroll self-assigned this Sep 5, 2022
@pygy
Copy link
Member

pygy commented Sep 5, 2022

As long as we deal with [is], we have a render bug in the update phase. is should be considered part of the element identity along with the tag name when diffing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barneycarroll barneycarroll

Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pygy @barneycarroll