Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex assetions like deepEquals and satisfies plugins should differentiate between bail outs and internal errors #48

Open
pygy opened this issue May 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pygy
Copy link
Member

pygy commented May 20, 2022

Currently, if a crash happens in the deepEquals code (as in #41), or in a .satisfies plugin, this is reported as a bailout.

Crashes in user code (e.g. an getter that throws when doing a deepEquals, or some other failure in user code called from the satisfies() validator) should cause bailouts, but errors in ospec and validators should throw errors and exit ASAP with a corresponding stack trace.

@pygy pygy self-assigned this May 20, 2022
@pygy pygy added the bug Something isn't working label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant