Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomAirModelManager::CheckEquipName function possible issues #6321

Open
3 tasks
mjwitte opened this issue Sep 18, 2017 · 3 comments · May be fixed by #10452
Open
3 tasks

RoomAirModelManager::CheckEquipName function possible issues #6321

mjwitte opened this issue Sep 18, 2017 · 3 comments · May be fixed by #10452
Assignees
@lgu1234
Labels
Defect Includes code to repair a defect in EnergyPlus MediumComplexityApproved Used for subcontractor defect complexity requests

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Sep 18, 2017

Issue overview

For #6272, need to eliminate use of ZoneEquipConfig.ReturnAirNode and search through all possible return nodes. Posting this issue now, but I will be working in this code, so any changes here should wait at least until #6272 is complete and merged.

Looking at this function, it is getting various zone equipment objects and assigning node names based on Alpha( n ). This is fragile if the alphas move there won't be any way to know this is broken (test file only uses PTACs). This should either use mining functions to get node numbers from the equipment, or after the JSON input processor drops in, this could grab node names using field names directly.

Also, this code for AirLoopHVACReturnAir does not look correct. Since there is no such object type, the alphas will be empty.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mjwitte
Copy link
Contributor Author

mjwitte commented Sep 18, 2017

@lgu1234 Hmm, all the supply nodes for air terminals use Alphas( 1 ) which looks incorrect.

@lgu1234
Copy link
Contributor

lgu1234 commented Sep 19, 2017

@mjwitte You are right. Most supply node names of air terminal objects are Alphas( 3 ). Some use 4, 5 and 9. I will wait until #6272 is merged.

@mjwitte
Copy link
Contributor Author

mjwitte commented Sep 19, 2017

@lgu1234 For the zone equipment, I noticed that there are already a set of functions to get the various nodes, e.g. FanCoilUnits::GetFanCoilZoneInletAirNode. They're used by SystemReports::ReportMaxVentilationLoad, so there's a full list of them here. Of course, this will force those to do a full getinput instead of the side path used here, so that may or may not be a good thing. Probably want to try one first before changing them all.

@lgu1234 lgu1234 self-assigned this May 25, 2018
@lgu1234 lgu1234 added the Defect Includes code to repair a defect in EnergyPlus label May 25, 2018
@dnels14 dnels14 added the MediumComplexityApproved Used for subcontractor defect complexity requests label Jul 28, 2023
@lgu1234 lgu1234 linked a pull request Mar 28, 2024 that will close this issue
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgu1234 lgu1234

Labels
Defect Includes code to repair a defect in EnergyPlus MediumComplexityApproved Used for subcontractor defect complexity requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor RAFN CheckEquipName for forced air zone equipment NREL/EnergyPlus
3 participants
@mjwitte @lgu1234 @dnels14