Allow negative peak temperatures for PhaseChangeHysteresis

[shorowit]

Issue overview

The IDD currently prevents negative peak melting/freezing temperatures for PhaseChangeHysteresis. Is there a reason the model can't allow negative values?

Two Unmet Hours requests for this:

• https://unmethours.com/question/70563/e-does-not-allow-non-positive-peak_freezing_temperature-or-peak_melting_temperature-for-phasechangehysteresis/
• https://unmethours.com/question/98752/negative-values-of-peak-meltingfreezing-temperatures-for-phasechangehysteresis/

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version)
• Version of EnergyPlus (if using an intermediate build, include SHA)
• Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[tpistochini]

I want to make you aware there are major issues with the energy calculations done by this object. We detail the problem in our ticket here: #10420

[Zakio12]

@tpistochini, does it solve the problem with negative values for the Peak Melting/Freezing Temperature?

[tpistochini]

We validated this model: https://github.com/BE-HVACR/Energyplus-EnhancedPCM but I do not know if it supports negative values for peak melting/freezing temperatures.

[Zakio12]

Thank you @tpistochini, for your feedback.
Was your model used in the newer version of EPlus to correct the problem of phase transitioning?
Do you have any idea?

Thanks again.

[tpistochini]

The model contained in EnergyPlus (even the newest version) does not work correctly. We found an alternate version written by Feng et al and we reviewed the source code, compiled it, and used it and it checked out against our experiments. If you'd like to do the same, my colleague Aref can likely give you some guidance on that: aaboud@ucdavis.edu. He could probably test if it will work with negative peak/melt temps.