Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeData Pressure is not initialized with physical value #10484

Open
tanaya-mankad opened this issue Apr 30, 2024 · 0 comments · May be fixed by #10485
Open

NodeData Pressure is not initialized with physical value #10484

tanaya-mankad opened this issue Apr 30, 2024 · 0 comments · May be fixed by #10485

Comments

@tanaya-mankad
Copy link
Collaborator

Issue overview

When writing feature tests, new NodeData objects are often created in isolation. However, initializing piecemeal attributes of an air node can result in an unphysical psychrometric state at the node. Unit tests which only initialize NodeData's Temp, HumRat, and Enthalpy leave all other attributes, including Pressure, at default-initialized values. Pressure values should at least be reasonably physical (i.e. not zero).

(An impossible air state (relative humidity > 1) was discovered in a model's Outdoor Air Mixer, while adding an unrelated feature. Attempting to "correct" the state's dry-bulb temperature exposed unit tests which have been calculating node conditions in a vacuum!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant