Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with GHE Construction from Single BH Objects #10494

Open
3 tasks
mitchute opened this issue May 3, 2024 · 0 comments · May be fixed by #10495
Open
3 tasks

Problem with GHE Construction from Single BH Objects #10494

mitchute opened this issue May 3, 2024 · 0 comments · May be fixed by #10495
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@mitchute
Copy link
Collaborator

mitchute commented May 3, 2024

Issue overview

The GHE model has a problem when constructing GHE objects from instances of single borehole objects. Instead of only using the single BH objects named, it is instead using all available. The problem occurs in this line:

for (auto &thisBH : state.dataGroundHeatExchanger->singleBoreholesVector) {

Instead of looping over all single BH objects, it should only consider the ones being passed through the vector in the argument. This would only be a problem if users were using this feature for GHE construction and also had multiple GHE or unused BH objects.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label May 3, 2024
@mitchute mitchute self-assigned this May 3, 2024
@mitchute mitchute linked a pull request May 3, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant