Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program temperature.py for other temperature models #47

Closed
MDKempe opened this issue Jan 23, 2024 · 4 comments
Closed

Program temperature.py for other temperature models #47

MDKempe opened this issue Jan 23, 2024 · 4 comments
Assignees

Comments

@MDKempe
Copy link
Collaborator

MDKempe commented Jan 23, 2024

Currently the temperature.py method will only run the sapm model. It should be able to run all of them.

@martin-springer
Copy link
Collaborator

@martin-springer
Copy link
Collaborator

temperature models we want to include: if temp_model == "sapm":

@tobin-ford
Copy link
Collaborator

tobin-ford commented May 20, 2024

Added a unified temperature function with pvlib temperature models. Live on dev_geospatial_scenario, complexity is a little higher than other pvlib functions to allow for its use during scenario analysis but this should be abstracted with its implementation into the scenario job pipeline.

@tobin-ford
Copy link
Collaborator

All temperature.cell function calls I could find across pvdeg have been replaced with the new temperature function and docstrings updated. New functions in the package should utilize temperature.temperature rather than temperature.cell or temperature.mod to ensure compatibility with scenario analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants