-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Groupby
ags output columns (even if they are counts) as Tags.CATEGORICAL
#1841
Comments
If I understand the example, the behavior of But since the workflow continues after that, the subsequent operators need to adjust the schemas of the columns they operate on in order to reflect the transforms they implement. It looks like |
@jperez999, could you point someone who isn't you (@radekosmulski, @oliverholworthy, @nv-alaiacano, or @edknv maybe, if they're willing) at how to fix this in the |
@karlhigley @radekosmulski tagging If a count column normalized afterwards, then it will take |
I think you're right about how things should ultimately be tagged, but I want to re-iterate that it's each op's responsibility to apply the appropriate tags based only on the transformation that op applies (not future or previous ops, who can take care of that for themselves.) If the result of a We don't want to be guessing what ops a user might apply subsequently in order to apply tags; we should just apply the currently correct tags and rely on subsequent ops to change them as needed. |
@karlhigley I agree. What I wanted to say should |
I don't know either 😄 |
Describe the bug
![image](https://private-user-images.githubusercontent.com/2444926/244607233-66a3556c-497c-40a4-bd68-9e08f3a4a662.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgxNDQ4OTksIm5iZiI6MTcxODE0NDU5OSwicGF0aCI6Ii8yNDQ0OTI2LzI0NDYwNzIzMy02NmEzNTU2Yy00OTdjLTQwYTQtYmQ2OC05ZTA4ZjNhNGE2NjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTFUMjIyMzE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWQ4NDAzNmE4ZmRmNjJlNjJiZmVhMjM4ZjZkYTE0M2Y0MWRhZTdjMzJlZTI3NjY4NjY2NWNhYTEyNTk5ZGNlMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.BVIsODx9yJNuU4kjP19hE48Gvvd0nzpgFM-e_wg5lYQ)
The output of the
Categorify
operator is tagged asTags.CATEGORICAL
even if those might just be counts.Steps/Code to reproduce bug
Here is a full reproducer:
Expected behavior
count
columns are not tagged asTags.CATEGORICAL
Environment details (please complete the following information):
current main
The text was updated successfully, but these errors were encountered: