Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] filter setting in the printer profile for some temperatures like heatbrake X on prusa MK4 #4935

Open
netinetwalker opened this issue Jan 23, 2024 · 3 comments
Labels
plugin available A plugin the implements this is available plugin idea Idea for a plugin request Feature request

Comments

@netinetwalker
Copy link

Is your feature request related to a problem? Please describe.

prusa MK4 temperatures include heatbrake cooling fan response and target X.

T:25.00/0.00 B:23.96/0.00 X:23.95/36.00 A:30.73/0.00 @:0 B@:0 HBR@:0
T:25.00/0.00 B:23.93/0.00 X:23.94/36.00 A:30.75/0.00 @:0 B@:0 HBR@:0
T:25.00/0.00 B:23.96/0.00 X:23.94/36.00 A:30.81/0.00 @:0 B@:0 HBR@:0

This causes some problems with plugins like:

Describe the solution you'd like

It would be nice to have a small filter setting in the printer profile for some temperatures

Describe alternatives you've considered

At the moment I use a small filter plugin to fix the problem on my mk4:

# coding=utf-8

def filter_heatbrake_temperatures(comm, parsed_temps):
    parsed_temps.pop("X", None)
    return parsed_temps

__plugin_name__ = "Filter Prusa MK4 heatbrake Temperatures"
__plugin_version__ = "0.0.1"
__plugin_description__ = "A quick heatbrake temperatures filter plugin for Prusa MK4"
__plugin_pythoncompat__ = ">=2.7,<4"
__plugin_hooks__ = {
    "octoprint.comm.protocol.temperatures.received": filter_heatbrake_temperatures
}

Additional context

No response

@github-actions github-actions bot added the request Feature request label Jan 23, 2024
@netinetwalker netinetwalker changed the title [Request] [Request] filter setting in the printer profile for some temperatures like heatbrake X on prusa MK4 Jan 23, 2024
@jneilliii
Copy link
Contributor

I had to deal with this issue with my power control plugins. It's definitely a pain. I suspect though since this is only on an isolated number of printers (so far only MK4, Mini, XL) not sure if a core feature is needed here, and rather your single file plugin should be registered on the plugin repository for others to find.

@netinetwalker
Copy link
Author

IMHO in the future it would be good to split the heater and cooling temperatures and targes in separated items.
One for all heaters one for all coolers ...
The old Interface provides only the heaters and the new function gives you the cooling Temps/Targets

Something like this?

heaters = self._printer.get_current_temperatures()
coolers = self._printer.get_current_cooler_temperatures()

@foosel
Copy link
Member

foosel commented Jan 23, 2024

I think in the future it would be good for 3d printer vendors to not make unilateral decisions about how to modify existing standard protocol messages - but that's not going to happen I guess, or it would already have done so 😉

As it's currently only one vendor, I'm leaning towards "plugin only" and the suggestion of @jneilliii

Should this become something that's also available in vendor agnostic firmware variants, we can think about core support.

@foosel foosel added plugin idea Idea for a plugin plugin available A plugin the implements this is available labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin available A plugin the implements this is available plugin idea Idea for a plugin request Feature request
Projects
Status: Todo
Development

No branches or pull requests

3 participants