Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] extend onBeforePrintStart to include selected file data #4951

Open
jneilliii opened this issue Feb 17, 2024 · 0 comments
Open

[Request] extend onBeforePrintStart to include selected file data #4951

jneilliii opened this issue Feb 17, 2024 · 0 comments
Labels
request Feature request

Comments

@jneilliii
Copy link
Contributor

Is your feature request related to a problem? Please describe.

While developing the Bambu plugin I was attempting to use the onBeforePrintStart viewmodel callback to pop my own print options modal prior to starting. If you use the load and print button from the file list the filesViewModel.selectedfile property is not populated with the file that the button was pressed from but the previously selected file if any. This means I have no way of knowing which file was selected to print.

Describe the solution you'd like

Would like to get the selected file data object (including name, path, storage, refs, etc.) added to the onBeforePrintStart callback to allow for further processing.

Describe alternatives you've considered

  • monkey patching filesViewModel.loadfile (probably will be my interim solution)
  • reordering the loadfile function to have the callbacks after file selection so that filesViewModel.selectedfile is populated prior
  • disabling the load and print button entirely and force selecting the file

Additional context

No response

@github-actions github-actions bot added the request Feature request label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Feature request
Projects
Status: Todo
Development

No branches or pull requests

1 participant