Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if octoprint.server.util.(loginFromApiKeyRequestHandler|loginFromAuthorizationHeaderRequestHandler) are still needed #4968

Open
foosel opened this issue Mar 11, 2024 · 1 comment
Labels
approved Issue has been approved by the bot or manually for further processing done Done but not yet released task A OctoPrint related task that needs to be taken care of as part of a milestone
Milestone

Comments

@foosel
Copy link
Member

foosel commented Mar 11, 2024

Problem

octoprint.server.util.(loginFromApiKeyRequestHandler|loginFromAuthorizationHeaderRequestHandler) currently duplicate some code and are likely superseded by the switch to using a request loader in flask_login now in the shape of octoprint.server.load_user_from_request.

Solution

Evaluate whether these methods and their dependencies can indeed be removed, and if so do that.

@foosel foosel added task A OctoPrint related task that needs to be taken care of as part of a milestone approved Issue has been approved by the bot or manually for further processing labels Mar 11, 2024
@foosel foosel added this to the 1.11.0 milestone Mar 11, 2024
@foosel foosel self-assigned this Mar 11, 2024
foosel added a commit that referenced this issue May 16, 2024
@foosel
Copy link
Member Author

foosel commented May 16, 2024

That's now cleaned up and hopefully still works as before.

@foosel foosel added the done Done but not yet released label May 16, 2024
@foosel foosel removed their assignment May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue has been approved by the bot or manually for further processing done Done but not yet released task A OctoPrint related task that needs to be taken care of as part of a milestone
Projects
Status: Done
Development

No branches or pull requests

1 participant