Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Kind" message enums #163

Open
6 tasks
daved opened this issue Jul 8, 2021 · 0 comments
Open
6 tasks

Add "Kind" message enums #163

daved opened this issue Jul 8, 2021 · 0 comments

Comments

@daved
Copy link
Member

daved commented Jul 8, 2021 •
edited

AC

  • Using PB enums (https://developers.google.com/protocol-buffers/docs/proto3#enum), add values for Ask/Offer as Kind (or better naming, please consult with the team)
  • Drop: AddTypeReq
  • Rename: TypeResp->KindResp, TypesResp->KindsResp, FndTypesReq->FndKindsReq
  • Ensure that the database migrations include "Kind" column (investigate what this looks like, probably id/int stored in field)
  • Add "Kind" enum: PostResp, AddPostReq, OvrPostReq, PostsResp, FndPostsReq,
  • *Expand on these AC as needed (please reach out and update the team)
@daved daved changed the title Add "Type" message enums Add "Kind" message enums Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daved