Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Join/Connect button language on activity pages #1120

Open
madprime opened this issue Oct 18, 2020 · 0 comments
Open

Improve Join/Connect button language on activity pages #1120

madprime opened this issue Oct 18, 2020 · 0 comments

Comments

@madprime
Copy link
Member

When on an activity page for an activity a member hasn't joined, there's a button inviting them to join it.

  1. Connect vs join: To join projects right now, it seems the activity pages say "Connect" for any OAuth2 project ("Connect project") regardless of whether it functions as a data source. This probably makes sense in a lot of cases (e.g. "connecting" fitbit intraday) but might be confusing at other times (e.g. any OAuth2 project that isn't primarily for "adding data"). We should look into whether there's a better logic on whether to say "Connect" instead of "Join".

  2. Study vs. project vs. activity: It seems that all activities say "Connect project" or "Join project". Since we're moving to say "activity" it seems that "project" should be retired here. Also, for any activity that is an official study, maybe it should say "study" instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant