Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert master branch to the react-revert branch and create new react branch with the contents of the current master #128

Open
xh3b4sd opened this issue Oct 17, 2016 · 1 comment

Comments

@xh3b4sd
Copy link

xh3b4sd commented Oct 17, 2016

Because of #127 I wanted to dig into the project and understand what is going on. I discovered there are differences in the package I have been installed in Atom and the code hosted on Github. On Github master is a file lib/file-service.js. This file is entirely missing in the package I have been installed. At this point I will simply remove the package because I have really no idea what is going on.

screen shot 2016-10-17 at 20 45 45

screen shot 2016-10-17 at 20 45 01

screen shot 2016-10-17 at 20 53 30

@Osmose
Copy link
Owner

Osmose commented Oct 17, 2016

The current released version is based on the react-revert branch; I attempted to rewrite the library using React to generate the frontend, but after deployment we ran into compatibility issues with other packages relying on React as well (see #116 (comment)).

I reverted the released version and put out a new release with the old code, which is currently maintained on the react-revert branch, while master contains the React-ified version of the lib. I haven't spent enough time working on this lately (and haven't received enough PRs to bother) to get around to reverting on master and maintaining a react branch.

Sorry that that was confusing, but you don't need to worry about getting the wrong package code or anything; the version up on atom.io is the correct version that should be released currently. I'll rename this issue to match the actual task of swapping the branches, whenever someone gets around to it.

@Osmose Osmose changed the title installed package does not equal Github repository content Revert master branch to the react-revert branch and create new react branch with the contents of the current master Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants