Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as a project folder does not work #130

Open
rumpelsepp opened this issue Nov 3, 2016 · 4 comments
Open

Add as a project folder does not work #130

rumpelsepp opened this issue Nov 3, 2016 · 4 comments

Comments

@rumpelsepp
Copy link

rumpelsepp commented Nov 3, 2016

I have read in the docs, that I can add a hightlighted path as a project folder using ctrl + alt + o on linux. In my machine it does not work. The advanced open file palette closes and nothing happens. What kind of information do you need from my side?

@Osmose
Copy link
Owner

Osmose commented Nov 3, 2016

Thanks for the report!

  1. Are you trying on a directory with a plus symbol on the side, or one without?
  2. Are you highlighting the entry with the keyboard, or with the mouse?
  3. If you open the DevTools (View -> Developer -> Toggle Developer Tools) and view the console, is anything logged when you try to add a project folder?
  4. Can you open the keybinding resolver (should be ctrl+. on Linux) and try to add a file with the shortcut? And then check what the resolver says after you hit the shortcut? It should show the advanced-open-file binding, but if it shows another binding, that one might be overriding ours.

@rumpelsepp
Copy link
Author

Thanks for your time!

  1. With a plus symbol.
  2. With the keyboard, since I am trying to gain a similar workflow as in vim with :e file.
  3. No, the console does not log anything.
  4. It shoes the advanced file open toggle command.

It is a bit strange. The palette closes and nothing happens. When I click the plus symbol with the mouse it works as inteded.

@Osmose
Copy link
Owner

Osmose commented Nov 25, 2016

I must've missed the notification that you replied, sorry for the late response!

Also I realize I'm a fool now. There's no default shortcut defined at all! 047401c is the commit that added the command, but it doesn't add a keybinding, even though it says it does in the README. Whoops!

This should be a quick fix. What would be your preferred shortcut? Maybe ctrl + shift + a?

@samestep
Copy link

What is the status of this issue? I also found it surprising that Ctrl-Alt-O does not work as specified in the README. Is this issue blocked by the need to decide on a default shortcut? If so, how can I define a custom shortcut for the command in my keymap.cson until a default shortcut is implemented? In any case, any references to a keyboard shortcut for this feature (e.g. those added in 047401c) should be removed until an actual keyboard shortcut is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants