Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Panel placement shifted below tab bar on One Dark theme #136

Open
eboracus opened this issue Jan 24, 2017 · 2 comments
Open

UI Panel placement shifted below tab bar on One Dark theme #136

eboracus opened this issue Jan 24, 2017 · 2 comments

Comments

@eboracus
Copy link

On Linux it seems the placement of the AOF panel when it pops up is shifted down to below the tab bar, instead of starting from the top of the window, see below:

aof_panel_location

This shift down also means that when the displayed directory has many files the panel reaches the bottom of the Atom window rather than leaving a nice gap by that same amount.

@Osmose Osmose changed the title UI Panel placement shifted below tab bar on Linux UI Panel placement shifted below tab bar on One Dark theme Jan 24, 2017
@Osmose
Copy link
Owner

Osmose commented Jan 24, 2017

Thanks for the report!

That's expected, insofar that One Dark has had that gap for a while (I think, anyway). It's a theme-specific bug, rather than a platform bug (unless you're also seeing that on, say, Atom Dark, which would be much more surprising).

AFAICT there's two options to fixing little styling bugs like this: either AOF maintains theme-specific fixes, or the skins do. Since I'm not bothered by the gap and no one has submitted fixes, AOF doesn't have any, but I've seen a few themes that actually have AOF-specific fixes. A lovely thing of them to do, they're fabulous for it. :D

I'm open to merging theme-specific fixes if anyone puts a PR up. Doesn't seem like a huge deal having them.

@eboracus
Copy link
Author

Yes you're right, my mistake. 👍 I wasn't seeing it on other platforms side-by-side, but see now that I'd forgotten to update the UI theme (above image is using atom-dark) on that machine to match the others 😕 ..(doesn't look hugely different on glance).

Switched over and problem solved here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants