Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of checked-in copy of graphql-js #1

Open
lastmjs opened this issue Jan 16, 2018 · 2 comments
Open

Get rid of checked-in copy of graphql-js #1

lastmjs opened this issue Jan 16, 2018 · 2 comments

Comments

@lastmjs
Copy link
Member

lastmjs commented Jan 16, 2018

Right now I've included a copy of https://github.com/graphql/graphql-js in this repo, because I needed to modify the paths of the ES module imports, because Zwitterion does not deal with implicit index.js files. Once Zwitterion is fixed, get rid of the local copy throughout the entire repository history. Also, the Node.js version of ES modules is being used just for iterall...so it is not a relative path. Hopefully Node.js just gets rid of that, but if not, we'll have to figure that one out still.

@lastmjs
Copy link
Member Author

lastmjs commented Jan 18, 2018

Perhaps we must admit defeat and use a bundler like Parcel, because even when all code is written in ES modules, Node.js code is going to use paths that aren't paths at all, and rely on metadata in package.json to find where modules' entry points are. This will require a bundler to use on the front end

@lastmjs
Copy link
Member Author

lastmjs commented Jan 18, 2018

Ignore the above comment, I'm going to hope for some bare imports to be allowed in the browser someday, and I'll update Zwitterion to cope: lastmjs/zwitterion#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant