Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Document G-Codes used in current firmware #35

Open
1 of 3 tasks
pschuster opened this issue Jan 24, 2018 · 3 comments
Open
1 of 3 tasks

Document G-Codes used in current firmware #35

pschuster opened this issue Jan 24, 2018 · 3 comments
Assignees

Comments

@pschuster
Copy link
Contributor

pschuster commented Jan 24, 2018

G-Codes are hardcoded in the firmware (see Printr.cpp). This has issues with sending files via WiFi and for overall flexibility.

As a first step we should document current G-Codes used and then decide where to split them or where to implement them. Documentation is required in Wiki

There are various possibilities:

  1. Keep them in the firmware as is (hard coded)
  2. G-Codes downloaded from the Cloud contain all G-Codes (i.e. G-Codes are generated in the cloud)
  3. G-Codes are stored on internal SD card.
  4. ...

Tasks

  • Document G-Codes used in current firmware
  • Discuss and decide where to put them (in this issue)
  • Create issues required for refactoring
@oddirmeyer
Copy link
Contributor

oddirmeyer commented Jan 25, 2018

Starting G-code descriptions updated and ready for review. @abdrumm Can you double-check for accuracy, please? https://github.com/Printrbot/Printrhub/wiki/G-Codes

@pschuster
Copy link
Contributor Author

pschuster commented Jan 25, 2018

Awesome. Thank you very much. That makes things easier I think. The next step would be to cluster those G-Codes in basic setup, and print preparation or should we do things like reset x and y and probing before each print?

What I mean is this: We could have basic printer setup in the firmware that runs when the printer is turned on, i.e. reseting X/Y, and probing Z. Then we would not need to have those G-Codes in files sliced in the cloud or at home, simplifying both aspects and users cannot make dump mistakes by copying wrong setup G-Codes in their slicer.

@abdrumm: Do we need to have that probing before each print? Or would it be enough to have that once when the printer is turned on?

@abdrumm
Copy link
Member

abdrumm commented Apr 4, 2018

I am ok w minimum viable product that works ;) so we don’t HAVE to do it before every print. I think since all printers probe before print, it’s just best practice... conservative but not necessary

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants