Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin peer dependency on @typescript-eslint/parser to avoid breaking when typescript-estree internals change #505

Open
rybesh opened this issue Jan 13, 2023 · 1 comment
Open

Pin peer dependency on @typescript-eslint/parser to avoid breaking when typescript-estree internals change #505

rybesh opened this issue Jan 13, 2023 · 1 comment

Comments

@rybesh
Copy link

rybesh commented Jan 13, 2023

Since typescript-eslint-language-service relies on internal APIs of typescript-estree, it is effectively locked to particular versions of @typescript-eslint/parser. So putting "@typescript-eslint/parser": ">= 5.0.0” in peerDependencies doesn’t make sense: new installs of typescript-eslint-language-service get recent versions of @typescript-eslint/typescript-estree that no longer work with it. It should be pinned to 5.26.0 as in devDependencies.
@adrian-gierakowski
Copy link

Related #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rybesh @adrian-gierakowski