Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localmap Fetch-Cycle is easily interrupted #23

Open
kitten opened this issue Dec 11, 2015 · 5 comments
Open

Localmap Fetch-Cycle is easily interrupted #23

kitten opened this issue Dec 11, 2015 · 5 comments
Assignees

Comments

@kitten
Copy link
Contributor

kitten commented Dec 11, 2015

The Localmap is updating itself by fetching a new localmap image when it received the one. This cycle is easily broken if the player is opening a menu, fast travelling, etc. Hence the command has to be sent at another point of the localmap component.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 11, 2015

Another annoyance is that with the current logic if the map is empty, it won't do an update which means that it won't fetch another.

@luckydonald
Copy link
Member

this is really an issue. Starting the app on a second screen on the same machine is already a struggle (#22), and with that I have to restart it every time.
Alt+tab out, restart, switch back to it, be quick enough to exit pause menu in time, etc.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 13, 2015

This behavior was much better before the introduction of React+Fluorine(+Redux). Something didn't transition well. Right now I'm getting up to speed on the tooling that was introduced then I'll tackle this tonight.

Poor workaround I've used: click About, then click Map again.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 14, 2015

It looks like @philplckthun has a branch for improving this, I'll assume he's going to squish this bug.

@luckydonald
Copy link
Member

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants