Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset signal #390

Open
ropg opened this issue Feb 23, 2024 · 2 comments
Open

Reset signal #390

ropg opened this issue Feb 23, 2024 · 2 comments

Comments

@ropg
Copy link
Contributor

ropg commented Feb 23, 2024

Some boards, notably the popular Heltec's ESP32_LoRa_v3, have the reset wire hooked up. It might be nice to pull that low for 50 ms or so when connecting. Could do a version of the constructor that has _rst an extra parameter (default -1 for no hw reset) between _scl and geometry. There's pros and cons since everything has default values, but given that geometry has its own type, people can't put int in there anyway. Right?

Good idea? Shall I create a PR for that?

@ropg
Copy link
Contributor Author

ropg commented Feb 23, 2024

I guess that would break code that does, say, SSD1306Wire display(0x3c, SDA, SCL, GEOMETRY_128_32);, so that leaves putting it all the way at the end, or having something like setResetPin(int _rst). Or deciding it out of scope.

@marcelstoer
Copy link
Member

I'd rather not add more constructor parameters. Especially so if they are for auxiliary functionality.

having something like setResetPin(int _rst)

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants