Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir library #267

Open
timwis opened this issue Mar 15, 2024 · 2 comments
Open

Elixir library #267

timwis opened this issue Mar 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@timwis
Copy link

timwis commented Mar 15, 2024

Hi team, I wrote an elixir module a few months ago to handle signing and verifying TrueLayer requests, and thought I'd extract it out into a module. Just wanted to share it here in case other elixir users stumble upon this repo in the future:

https://github.com/timwis/ex_truelayer_signing

Happy to submit it as a PR here if you like - I don't need to be the package owner or anything. I don't quite have your test coverage, though it shouldn't be too hard to add it. But no worries if you don't want to take on the maintenance of another language.

@timwis timwis added the enhancement New feature or request label Mar 15, 2024
@kplattret
Copy link
Member

Hi @timwis, thanks a lot for sharing this! I actually considered writting an Elixir library for this some time back, so if people need one, then it makes sense for us to support it. I'd be happy to help you move it here if that's what you'd like.

I would need to extend the test coverage and we would indeed need to move ownership to TrueLayer for security reasons, but of course we would keep you as an author of the package.

If the above sounds good to you, then perhaps when ready we could release it under a new name (e.g. truelayer_signing) and let the old one be, or deprecate it. What do you think?

@timwis
Copy link
Author

timwis commented Apr 9, 2024

Thanks @kplattret that all sounds great. And regarding the name, that makes sense. I deliberately named it with the ex_ prefix so there wouldn't be a conflict, and I'd be happy to deprecate it when replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants